Migrate VisualizationEmbed to React #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Nov 17, 2019
| alt="Redash Logo" | ||
| style={{ height: '24px', verticalAlign: 'text-bottom' }} | ||
| /> | ||
| <VisualizationName visualization={visualization} />{' '} |
There was a problem hiding this comment.
I think we no longer need the react2angular definition of this component...
Closed
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Migration of VisualizationEmbed to React
All as is, with one small difference in the "Open in Redash" icon, I changed the icon to "External Link" instead of "Link".
I also changed the Refresh button because it doesn't seem to work in the Visualization Embed context, lmk if I should handle that differently 🙂
Related Tickets & Documents
#3071
Mobile & Desktop Screenshots/Recordings (if there are UI changes)