Parameter feedback - #2 Client errors in query page #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
force-pushed
the
param-feedback-2
branch
from
b42e0d6
to
bad3f14
Compare
* Parameter feedback - #3 Added in Widgets * Added cypress tests * Making sure widget-level param is selected * Parameter feedback - #4 Added in Dashboard params (#4321) * Parameter feedback - #4 Added in Dashboard params * Added cypress test * Moved to service * Parameter feedback - #5 Unsaved indication (#4322) * Parameter feedback - #5 Unsaved indication * Added ANGULAR_REMOVE_ME * Added cypress test * Fixed percy screenshot * Some code improvements * Parameter input feedback - #6 Better value normalization (#4327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that #4312 brings query result
errorData, we can show them inline in context.This PR is for the query page only
Notice, since the client is oblivious to the error's meaning (it's evaluated in the server), it can't be responsible for it's hiding. For instance, if a parameter was left empty, it displays "Required parameter". Once the user fills the field in, the client doesn't know that the error has been fulfilled - so it can't hide the error.
This causes a jarring user experience. As a user you expect the error indication to disappear immediately when fixed. To mitigate this I implemented a "touched" flag on each parameter which removes the red indication but keeps the error text visible, until re-evaluated by the server. This works well.
Any change to parameter - be it value or settings - toggles on the "touched" flag. The flag resets when the error data from the server has changed.
To accommodate the error messages, more bottom spacing has been given to the parameters.