Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Choropleth visualization to React #4313

Merged
merged 10 commits into from
Nov 14, 2019
Merged

Migrate Choropleth visualization to React #4313

merged 10 commits into from
Nov 14, 2019

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Oct 29, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor

Description

Related Tickets & Documents

#3301 (Migrate Visualizations to React -> Choropleth)

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image
image
image
image

@kravets-levko kravets-levko added Frontend Visualizations Frontend: React Frontend codebase migration to React labels Oct 29, 2019
@kravets-levko kravets-levko self-assigned this Oct 29, 2019
@arikfr arikfr mentioned this pull request Oct 29, 2019
Closed
24 tasks
@weekly-digest weekly-digest bot mentioned this pull request Nov 4, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Nov 11, 2019
Closed
@kravets-levko kravets-levko marked this pull request as ready for review November 13, 2019 08:59
arikfr
arikfr requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The map is smaller than previously (try this vs. this).
  2. In the editor, "Show Legend" seems to have no effect.
  3. Clicking on "Bounds" crashes.
  4. The format specs for the value column should be a HelpTrigger and open the sidebar, no?

@kravets-levko
Copy link
Collaborator Author

@arikfr 1-3 fixed; regarding 4: currently it just shows a link in all editors; maybe I'll better address this during doing refinements I planned for all editors, WDYT?

@arikfr
Copy link
Member

arikfr commented Nov 14, 2019

maybe I'll better address this during doing refinements I planned for all editors, WDYT?

Sounds good 👍

@arikfr arikfr merged commit 1a95904 into master Nov 14, 2019
@arikfr arikfr deleted the migrate-choropleth-to-react branch November 14, 2019 13:42
@kravets-levko kravets-levko mentioned this pull request Nov 14, 2019
Merged
1 task
@weekly-digest weekly-digest bot mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr requested changes

@gabrieldutra gabrieldutra Awaiting requested review from gabrieldutra

Assignees

@kravets-levko kravets-levko

Labels
Frontend: React Frontend codebase migration to React Frontend Visualizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kravets-levko @arikfr