Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter input feedback #4264

Closed
wants to merge 12 commits into from
Closed

Parameter input feedback #4264

wants to merge 12 commits into from

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 18, 2019 •
edited
Loading

  • Feature

Description

Fixes #2721.
This is similar to #4197 but validation is done server-side post execution.

@ranbena
Copy link
Contributor Author

ranbena commented Oct 18, 2019

@arikfr this is the server-side implementation of param validation.
The code is not optimal yet, but it behaves just as we aimed for.

Take it for a spin https://deploy-preview-4264--redash-preview.netlify.com/

@ranbena
Copy link
Contributor Author

ranbena commented Oct 18, 2019

Take it for a spin https://deploy-preview-4264--redash-preview.netlify.com/

Actually, there's backend changes so the preview won't work. Need to test locally.

@ranbena
Copy link
Contributor Author

ranbena commented Oct 20, 2019

Added some new features:

Unsafe param

Shows the exact param/s violating safe execution.

Screen Shot 2019-10-21 at 0 35 14

Unsaved param

When adding a new param but not yet saving the query.
The warning color is a bit meh but will leave styling to finish line.

Screen Shot 2019-10-21 at 0 36 38

@ranbena
Copy link
Contributor Author

ranbena commented Oct 20, 2019 •
edited
Loading

I'm stuck on some bug regarding the "touched" prop. Hope to find a solution soon and request UX review.

@ranbena
Copy link
Contributor Author

ranbena commented Oct 21, 2019

All error feedback cases from this PR are elaborated on in detail and up for discussion in https://discuss.redash.io/t/query-parameter-validation-and-feedback/4759.

@ranbena ranbena mentioned this pull request Oct 21, 2019
Closed
1 task
@weekly-digest weekly-digest bot mentioned this pull request Oct 21, 2019
Closed
@ranbena ranbena self-assigned this Oct 21, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 28, 2019
Closed
@ranbena
Copy link
Contributor Author

ranbena commented Oct 30, 2019

Split into multiple PRs starting from #4312

@ranbena ranbena closed this Oct 30, 2019
@guidopetri guidopetri deleted the param-server-validation branch July 22, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "missing parameter value" message friendlier
1 participant
@ranbena