Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy snapshot: make sure query results are consistent #4246

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Oct 15, 2019

What type of PR is this? (check all applicable)

  • Other

Description

Make sure the query results have the same order in all screenshots.

Example failure this should fix: https://percy.io/Redash/redash/builds/2821287/view/180328320/1280?mode=diff&browser=chrome&snapshot=180328320

@arikfr arikfr merged commit 27cd767 into master Oct 15, 2019
@arikfr arikfr deleted the percy-stability branch October 15, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants