Fix double-scrollbar when in fullscreen #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
Oct 16, 2019
client/app/assets/less/inc/base.less
Outdated
Comment on lines
27
to
31
| &.headless { | ||
| padding-top: 10px; | ||
|
|
||
|
|
||
| app-view { | ||
| min-height: ~"calc(100vh - 10px)"; |
There was a problem hiding this comment.
I think this would be a simpler solution:
&.headless {
padding-top: 10px; // <- remove this line
app-view {
padding-top: 10px; // <- move it to here
}There was a problem hiding this comment.
Indeed. Didn't realize app-view is the only thing that renders inside the body. Pushing in a bit.
ranbena
approved these changes
Oct 16, 2019
|
Gracias @stefanmaric |
No hay de qué, @ranbena 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When using fullscreen mode inside an embedded report, a double scrollbar appears because padding is added to the
bodybut the container is set to bemin-height: 100vh. This PR fixes it.