Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Misleading warning when trying to download results of unsaved query #4219

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Fix: Misleading warning when trying to download results of unsaved query #4219

merged 1 commit into from
Oct 6, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 6, 2019 •
edited
Loading

  • Bug Fix

Description

Fixes #4218

Changed to target="_blank" so there's no redirect prompt.
Added download attribute to prevent new tab from opening.

@ranbena ranbena requested a review from arikfr October 6, 2019 12:46
@ranbena ranbena self-assigned this Oct 6, 2019
@ranbena
Copy link
Contributor Author

ranbena commented Oct 6, 2019

@arikfr check it out https://deploy-preview-4219--redash-preview.netlify.com/

@ranbena ranbena marked this pull request as ready for review October 6, 2019 12:47
@ranbena ranbena merged commit 2f42b81 into master Oct 6, 2019
@ranbena ranbena deleted the download branch October 6, 2019 13:00
@weekly-digest weekly-digest bot mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr approved these changes

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading warning when trying to download results of unsaved query
2 participants
@ranbena @arikfr