Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query runner for Intersystems IRIS #4214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxliu
Copy link

@maxliu maxliu commented Oct 4, 2019

What type of PR is this? (check all applicable)

Intersystem IRIS (or CACHE) is widely used in the hospitals, bank and other industries. This query runner uses pyodbc witch IRIS support to connect to the databases.

  • New Query Runner (Data Source)

Description

This query runner use pyodbc package to build connection to IRIS database.

Related Tickets & Documents

document for IRIS Support for pyodbc Python ODBC Bridge

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@maxliu maxliu changed the title Add query runner for Intersystems IRIS. need pyodbc package. Add query runner for Intersystems IRIS Oct 4, 2019
@guidopetri
Copy link
Contributor

@maxliu , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? I think we also have an ODBC connector now, as well - maybe that's useful here?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

justinclift commented Jul 17, 2023

The merge conflict looked pretty straight forward to fix, so I just went ahead and did it. Looking at the ODBC Support info on the InterSystems IRIS page (new url), it has this:

An InterSystems-specific implementation of DB API 2.0 was introduced with InterSystems IRIS 2022.1 (see
“Using the Python DB-API” in Using the Native SDK for Python), and is recommended for all new Python
development. The pyodbc implementation is still supported, and may be required for client applications
that connect to older versions of InterSystems IRIS.

If lots of people start using Redash with InterSystems IRIS, then it might be useful for someone to look at that "Native SDK for Python" they talk about.

@justinclift
Copy link
Member

The backend-lint CI test is failing. Looks fairly simple to fix though:

Run flake8 .
./redash/query_runner/intersysiris.py:18:17: E126 continuation line over-indented for hanging indent
./redash/query_runner/intersysiris.py:66:13: E126 continuation line over-indented for hanging indent
./redash/query_runner/intersysiris.py:143:33: E126 continuation line over-indented for hanging indent
Error: Process completed with exit code 1.

@maxliu Hopefully you're still interested in this getting completed and merged. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants