Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multi-value Dropdown not available in Static Value edit dialog #4213

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Fix: Multi-value Dropdown not available in Static Value edit dialog #4213

merged 2 commits into from
Oct 5, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 4, 2019

  • Bug Fix

Description

Fixes #4212.

Screen Shot 2019-10-04 at 15 55 58

@ranbena ranbena self-assigned this Oct 4, 2019
gabrieldutra
gabrieldutra approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@gabrieldutra gabrieldutra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it will be more future-proof if we change ParameterValueInput to base those settings in the Parameter directly, but I have a feeling that can cause some issues with re-rendering. Anyway, this will do it for now :)

@gabrieldutra
Copy link
Member

On a second thought, moving only the allowMultipleValues to be extracted from the param prop that already is in the ParameterValueInput may be simple and safe, wdyt?

@ranbena
Copy link
Contributor Author

ranbena commented Oct 5, 2019

On a second thought, moving only the allowMultipleValues to be extracted from the param prop that already is in the ParameterValueInput may be simple and safe, wdyt?

That was my approach at first, but I felt it was too much code changes for a simple fix.
Anywho 8d140c1

@ranbena ranbena merged commit 648847d into master Oct 5, 2019
@ranbena ranbena deleted the multi branch October 5, 2019 14:52
@weekly-digest weekly-digest bot mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldutra gabrieldutra gabrieldutra approved these changes

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Multi-value Dropdown not available in Static Value edit dialog
2 participants
@ranbena @gabrieldutra