Migrate Public Dashboard Page to React #4203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
commented
Oct 3, 2019
Comment on lines
+149
to
159
| return this.queryResult.toPromise() | ||
| .then((result) => { | ||
| this.loading = false; | ||
| this.data = result; | ||
| return result; | ||
| }) | ||
| .catch((error) => { | ||
| this.loading = false; | ||
| this.data = error; | ||
| return error; | ||
| }); |
There was a problem hiding this comment.
I think this has been playing around with me for a while (in here and in the Widget Migration).
It was returning the queryResult before updating this.data, which was a weird result when I expected the widgets to render an error and they were not doing it
gabrieldutra
force-pushed
the
react-public-dashboard
branch
from
f83b492
to
bce0d97
Compare
gabrieldutra
commented
Oct 3, 2019
| this.dashboard = new Dashboard(data); | ||
| this.dashboard.widgets = Dashboard.prepareDashboardWidgets(this.dashboard.widgets); | ||
| this.dashboard.widgets.forEach(widget => this.loadWidget(widget, !!refreshRate)); | ||
| this.filters = []; // TODO: implement (@/services/dashboard.js:collectDashboardFilters) |
There was a problem hiding this comment.
I've added the Dashboard filters in this PR 👍
Closed
|
Closing this to deliver with #4228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Migration of the Public Dashboard Page to React
To-do list:
Issues to verify in this PR:
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)