Vertica: prevent overwriting row data when duplicated column names exist #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks 👍 |
NicolasLM
reviewed
Oct 3, 2019
| 'type': types_map.get(col[1], None)} for col in columns_data] | ||
| columns_data = [(i[0], types_map.get(i[1], None)) for i in cursor.description] | ||
|
|
||
| columns = self.fetch_columns(column_data) |
There was a problem hiding this comment.
Hi, I stumbled upon this commit while rebasing my work on master.
Tell me if I'm missing something but it looks like column_data is not defined anywhere. Shouldn't it be columns_data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues with duplicated column names for Vertica query runner.
fetch_columns method is used for this fix.
Problem Description:
If we have columns with the same name in the select statement then the query result is overridden by the value of first column. e.g.
select count(*) , count(distinct user_id) , count(user_id) from example_tableExample:
Duplicated column names -- 2nd and 3rd columns' values were overwritten by the 1st column:
A simple fix is to give each column a unique name: