Alert page 404 #4180
Merged
Alert page 404 #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Sep 24, 2019
There was a problem hiding this comment.
We actually have standard behavior for 404s. You can trigger it either by returning the logic of loading the alert to the route's resolve or by throwing the relevant exception. I don't remember the details, but maybe @kravets-levko remembers / has relevant example?
|
Updated 👍
|
kravets-levko
approved these changes
Sep 24, 2019
arikfr
approved these changes
Sep 24, 2019
gabrieldutra
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle Alert 404.
Before:
After: