Alert redesign #3 - Destinations single pane mode #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
force-pushed
the
alert-3-dialog
branch
2 times, most recently
from
03b645a
to
6541a05
Compare
2 tasks
ranbena
force-pushed
the
alert-2-destinations
branch
from
0917d56
to
8d9587a
Compare
ranbena
force-pushed
the
alert-3-dialog
branch
from
6541a05
to
cbfd25f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SelectItemsDialogis great for selecting users for groups but for Alert Destinations it feels too big and complex. I made some changes to allow a single pane mode for this dialog.All existing dialogs remain unchanged, except for Alert Destinations.
New features:
Before:
After: