Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dropdown parameter options appearing behind Dialog #4109

Merged
merged 4 commits into from
Sep 2, 2019
Merged

Fix Dropdown parameter options appearing behind Dialog #4109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8554f99
Fix typo
gabrieldutra Sep 1, 2019
77993eb
Add getPopupContainer to Dropdown parameters
gabrieldutra Sep 1, 2019
1a51236
Revert "Add getPopupContainer to Dropdown parameters"
gabrieldutra Sep 1, 2019
755cf3a
Remove .ant-dropdown-in-bootstrap-modal
gabrieldutra Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions client/app/assets/less/ant.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@
}
}

// Fix for Ant dropdowns when they are used in Boootstrap modals
// ANGULAR_REMOVE_ME Remove when all dialogs will be migrated to React (also search and remove usages)
.ant-dropdown-in-bootstrap-modal {
z-index: 1050;
}

// Button overrides
.@{btn-prefix-cls} {
transition-duration: 150ms;
Expand Down
2 changes: 1 addition & 1 deletion client/app/components/EditParameterSettingsDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function EditParameterSettingsDialog(props) {
</Select>
</Form.Item>
{param.type === 'enum' && (
<Form.Item label="Values" help="Dropdown list values (newline delimeted)" {...formItemProps}>
<Form.Item label="Values" help="Dropdown list values (newline delimited)" {...formItemProps}>
<Input.TextArea
rows={3}
value={param.enumOptions}
Expand Down
1 change: 0 additions & 1 deletion client/app/components/ParameterValueInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ class ParameterValueInput extends React.Component {
value={value}
onChange={this.onSelect}
dropdownMatchSelectWidth={false}
dropdownClassName="ant-dropdown-in-bootstrap-modal"
showSearch
showArrow
style={{ minWidth: 60 }}
Expand Down
1 change: 0 additions & 1 deletion client/app/components/QueryBasedParameterInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export class QueryBasedParameterInput extends React.Component {
value={isArray(value) ? value : toString(value)}
onChange={onSelect}
dropdownMatchSelectWidth={false}
dropdownClassName="ant-dropdown-in-bootstrap-modal"
optionFilterProp="children"
showSearch
showArrow
Expand Down