Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Mac browser’s scrollbar obscuring content #3830

Merged
merged 1 commit into from
May 27, 2019
Merged

Fix for Mac browser’s scrollbar obscuring content #3830

merged 1 commit into from
May 27, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented May 25, 2019

  • Bug Fix

Description

In table visualizations two visual bugs occur on Mac browsers (FF, SF, CH):

  1. Scrollbar obscures table content. Solved in this PR.
  2. After scroll the bar doesn't disappear in CH, SF. There's an open bug for it and very recent discussions.

Mobile & Desktop Screenshots

Before:

Screen Shot 2019-05-24 at 18 48 52

After:

Screen Shot 2019-05-24 at 18 48 35

@ranbena ranbena self-assigned this May 25, 2019
@kravets-levko
Copy link
Collaborator

@ranbena There are issues on Linux (Chrome and FF, didn't have a chance to test on Windows) - before & after:
image
image

@arikfr
Copy link
Member

arikfr commented May 26, 2019

The same happens on Windows/Chrome. Is there a way to target a specific OS?

@gabrieldutra
Copy link
Member

Perhaps remove the margin-bottom: -10px; // compensation will make this acceptable?

@ranbena
Copy link
Contributor Author

ranbena commented May 26, 2019

10x @kravets-levko.

New approach:

.table.table-condensed {
  tbody > tr:last-child > td {
    padding-bottom: 15px; // <-- make room for scrollbar within the last row
  }
}

@ranbena
Copy link
Contributor Author

ranbena commented May 26, 2019

The same happens on Windows/Chrome. Is there a way to target a specific OS?

Not natively I believe but it's possible though I would avoid it unless last resort.

@ranbena
Copy link
Contributor Author

ranbena commented May 26, 2019

Perhaps remove the margin-bottom: -10px; // compensation will make this acceptable?

It's a viable option. Though it would be a tradeoff in both Mac and Win/Lin.

@ranbena
Copy link
Contributor Author

ranbena commented May 26, 2019

Looking into this further I suggest:

  1. 1st solution (dynamic-table bottom padding)
  2. Only for mac - with js and css.
  3. Revert commit completely when Chrome bug is fixed and published.

@ranbena
Copy link
Contributor Author

ranbena commented May 26, 2019

@kravets-levko ready for review

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Linux and Windows looks fine (as it was before these changes), so approved. But I didn't test on Mac - so I rely on anyone who can test it.

@ranbena ranbena requested a review from arikfr May 26, 2019 20:01
@arikfr arikfr merged commit 7679df6 into master May 27, 2019
@arikfr arikfr deleted the scroll branch May 27, 2019 15:31
@arikfr
Copy link
Member

arikfr commented May 27, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants