Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data Source Lifecycle Events #3828

Merged
merged 1 commit into from
May 27, 2019
Merged

Update Data Source Lifecycle Events #3828

merged 1 commit into from
May 27, 2019

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

This updates Data Source Lifecycle Events.

  • Add event when someone opens the new data source dialog.
  • Add event when someone edits a data source (on the backend) - didn't add the edited keys, but tell me if this adds value.
  • Update Test Connection event to include result of test - result added in a result key.

Note: Backend-wise the name for the object_type is "datasource" and in the frontend it is "data_source", I didn't change this as it could break existing tracking, but lmk if I should.

Related Tickets & Documents

Closes #3787.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@gabrieldutra gabrieldutra self-assigned this May 23, 2019
@arikfr arikfr merged commit 28e9740 into master May 27, 2019
@arikfr arikfr deleted the data-source-events branch May 27, 2019 16:28
@arikfr
Copy link
Member

arikfr commented May 27, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source Lifecycle Events
2 participants