Migrate CreateDashboardDialog to React #3826
Conversation
kravets-levko
added
Frontend
Frontend: React
| } | ||
| }, 100); | ||
| return () => clearTimeout(timer); | ||
| }, []); |
There was a problem hiding this comment.
I think you can substitute this for <Input autofocus />, no?
There was a problem hiding this comment.
It does not work in modals. This fix was suggested in related discussion
There was a problem hiding this comment.
Weird, it seems to work on CreateSourceDialog and ChangePasswordDialog 🤔
There was a problem hiding this comment.
@gabrieldutra I'll check once more
There was a problem hiding this comment.
@gabrieldutra I see that autoFocus works in other modals, but it doesn't work in this one - I really have no idea what's wrong 🤔 I tried to simplify that dialog as much as I can - removed almost all attributes, <DynamicComponent>, etc. - just <Modal ...><Input autoFocus /></Modal> - input does not get focused.
There was a problem hiding this comment.
There's one significant difference - Class component vs Functional component 🤔
There was a problem hiding this comment.
@ranbena Interesting idea. I'll try to implement it as class component - will see what happens.
There was a problem hiding this comment.
@ranbena Tried class component - the same issue (no autofocus).
Upd.: When this dialog is opened from React code - Input gets autofocus, when from Angular - no. I'll add a comment with ANGULAR_REMOVE_ME
There was a problem hiding this comment.
When this dialog is opened from React code - Input gets autofocus, when from Angular - no.
Makes sense and also good to know this sort of thing happens 🤔
There was a problem hiding this comment.
Yeah... But usually applications are built using only one framework, so such shit does not happen 🙂
What type of PR is this? (check all applicable)
Description
Migrate CreateDashboardDialog to React. Restore some
DynamicComponentusages (missed during React migration).Mobile & Desktop Screenshots/Recordings (if there are UI changes)