delete variable #3813
Merged
delete variable #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
May 22, 2019
| @@ -251,7 +251,6 @@ def run_query(self, query, user): | |||
| step["$sort"] = SON(sort_list) | |||
|
|
|||
| if not aggregate: | |||
| s = None | |||
There was a problem hiding this comment.
It looks like this whole if block can be removed, as it being overridden below.
There was a problem hiding this comment.
that's exactly. thanks!
|
Thanks for the reviews @arikfr . I updated code. Please review once again! |
|
So it took me a while to get back to this, but it's merged now. Thanks. |
This was referenced Sep 5, 2021
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I found variable don't used and re-declarate. So it deleted
Related Tickets & Documents