Cypress tests for query parameters #3810
Conversation
| afterEach(() => { | ||
| cy.getByTestId('SaveButton').click(); | ||
| cy.url().should('match', /\/queries\/\d+\/source/); | ||
| }); |
There was a problem hiding this comment.
You sure this is needed? Can leave new query unsaved.
There was a problem hiding this comment.
It's either save the query or this workaround 😬
|
Suggesting to add tests in Dashboard context. |
Mostly I want to test the -- Just to share some points I was thinking about:
|
I mean specifically test the "apply" functionality in the dashboard context, that it triggers widget refresh.
For what purpose? To db-seed these queries? |
|
Great initiative! |
|
It seems that Cypress has an issue when it's necessary to click more than once on Antd's Date Calendar, the first click works, the following ones don't ^^. This affected creating specs for DateTime and DateRanges. I think my last test will be to trigger DateTime by clicking enter or clicking outside the panel.
I thought about adding a smaller test just to make sure the behavior extends to the dashboard context, but this is sort of already happening with specs that rely on that behavior (e.g: "Height behavior on refresh"). Do you think we gain any value by having that separate?
🤔. I though more about development and unautomated tests. After running Cypress you'd get Redash with a basic set of organized data (in this case, queries that you could test each parameter). I'll think better about it, perhaps sth not for now as I don't really use Cypress data after it runs (and guessing nobody actually does it here). |
| @@ -19,11 +19,11 @@ export function createQuery(data, shouldPublish = true) { | |||
| }, data); | |||
|
|
|||
| // eslint-disable-next-line cypress/no-assigning-return-values | |||
| let request = cy.request('POST', '/api/queries', merged); | |||
| let request = cy.request('POST', '/api/queries', merged).then(({ body }) => body); | |||
There was a problem hiding this comment.
To be consistent with the shouldPublish = true changed it to return the body directly.
What type of PR is this? (check all applicable)
Description
Following #3737 (and the bug #3803) I wanted to add a few tests to another important part of Redash: Query parameters 😁
Parameters:
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)