Encapsulate query strings #3687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 8, 2019 08:26
…ery-string module
6 tasks
client/app/services/query.js
Outdated
| } | ||
|
|
||
| return qs.toString(Object.assign(...this.get().map(p => p.toUrlParams()))); | ||
| return qs.toString(this.getValues()); |
There was a problem hiding this comment.
I think it's better to use param.toUrlParams() instead of mapping name => value directly - it provides some layer of abstraction for a case when param will need some different serialization logic in future.
There was a problem hiding this comment.
What I'm trying to achieve with this refactoring is moving out the serialization logic from Parameter/Parameters and into the query string module. The approach here is that a query string is itself the serialization "view", thus the logic resides there and the model simply reveals its data.
|
This is no longer needed, right? |
|
@arikfr it was never needed, but I guess at this point it'll be better to revisit this at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)