Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1414] Word Cloud Word Frequency Selection #3668

Closed
wants to merge 8 commits into from

Conversation

mohamagdy
Copy link

@mohamagdy mohamagdy commented Apr 1, 2019

What type of PR is this?

  • Feature

Description

This PR addresses part of #1414 which is the ability to pass the frequency when creating "Word Cloud"

Related Tickets & Documents

Related GitHub issue #1414

@mohamagdy mohamagdy changed the title 1414 word cloud frequency [#1414] Word Cloud Word Frequency Selection Apr 1, 2019
@mohamagdy
Copy link
Author

@truebit I can see there are some merge conflicts with the files changed in this pull request. @kravets-levko might have introduced a new algorithm for showing words in the Word Cloud in the changes he applied but not sure.

If you have not applied @kravets-levko changes to the files client/app/visualizations/word-cloud/index.js and client/app/visualizations/word-cloud/word-cloud-editor.html then I can help with this.

@truebit
Copy link

truebit commented May 22, 2019

I figured out, need to npm run build in client directory to apply the changes.
Thanks @mohamagdy

<div class="form-group">
<label class="col-lg-6">Word Cloud Frequency Column Name</label>
<div class="col-lg-6">
<select ng-options="name for name in [''].concat(queryResult.getColumnNames())" ng-model="visualization.options.frequency" class="form-control"></select>
Copy link

@truebit truebit May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be an extra blank option when creating the word cloud. Demo like below:
图片

after saving it, this symptom will disappear.

@arikfr
Copy link
Member

arikfr commented Aug 11, 2019

Thank you for your effort on this!

As this was implemented as part of the React migration in #3930 closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants