feature: add couchbase query runner #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Apr 14, 2019
redash/query_runner/couchbase.py
Outdated
| def test_connection(self): | ||
| result = self.call_service(self.noop_query, '') | ||
|
|
||
| def get_buckets(self, query, nameParam): |
There was a problem hiding this comment.
nameParam should be name_param to be consistent with PEP-8/our naming convention.
There was a problem hiding this comment.
@arikfr. thx for review. Fixed nameParams.
redash/query_runner/couchbase.py
Outdated
| port = self.configuration.get('port', 8095) | ||
| params = {'statement': query} | ||
|
|
||
| url = "http://%s:%s/query/service" % (host, port) |
There was a problem hiding this comment.
Does Couchbase support HTTPS? In such case, we should probably make the protocol (http) configurable.
There was a problem hiding this comment.
extracted as parameter
|
Hi @arikfr. Updated PR. Can you check if we can proceed further? |
|
Merged. Thanks! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* feature: add couchbase query runner * fix style * fix style * fix style * fix naming due to convention * extracting protocol as parameter
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Connector for Couchbase 5x+
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)