Fix email shows as unverified when no email server is configured #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2019 12:36
as not verified and sending out a verification e-mail
there's no e-mail server to verify them
ghost
assigned
rauchy
commented
Mar 20, 2019
| @@ -141,6 +141,11 @@ def all_settings(): | |||
| MAIL_MAX_EMAILS = os.environ.get('REDASH_MAIL_MAX_EMAILS', None) | |||
| MAIL_ASCII_ATTACHMENTS = parse_boolean(os.environ.get('REDASH_MAIL_ASCII_ATTACHMENTS', 'false')) | |||
|
|
|||
|
|
|||
| def email_server_is_configured(): | |||
There was a problem hiding this comment.
Figured it's best to hide this instead of relying on MAIL_DEFAULT_SENDER in different places in the app, in case we ever want to change the criteria.
arikfr
deleted the
fix-email-shows-as-unverified-when-no-server-configured
branch
|
👍 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
…redash#3613) * check that e-mail server is configured before marking the email address as not verified and sending out a verification e-mail * use helper method in `invite_user` * move email_server_configured helper to settings * add test to verify that email addresses arent marked as unverified if there's no e-mail server to verify them * simplify a couple of tests with patch * combine conditions into single variable * Booleans, gotta love 'em
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #3608
Mobile & Desktop Screenshots/Recordings (if there are UI changes)