Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nest query ACL to dropdowns #3544

Merged
merged 22 commits into from
Mar 20, 2019
Merged

Nest query ACL to dropdowns #3544

merged 22 commits into from
Mar 20, 2019

Commits on Mar 19, 2019

  1. change API to /api/queries/:id/dropdowns/:dropdown_id

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    70e86a5 View commit details
    Browse the repository at this point in the history

  2. extract property

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    4a8a377 View commit details
    Browse the repository at this point in the history

  3. split to 2 different dropdown endpoints and implement the second

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    00a1bfc View commit details
    Browse the repository at this point in the history

  4. make access control optional for dropdowns (assuming it is verified at a 

    different level)
    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    87d959f View commit details
    Browse the repository at this point in the history

  5. add test cases for /api/queries/:id/dropdowns/:id

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    a09d151 View commit details
    Browse the repository at this point in the history

  6. use new /dropdowns endpoint in frontend

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    f1a585c View commit details
    Browse the repository at this point in the history

  7. require access to dropdown queries when creating or updating parent 

    queries
    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d5b809b View commit details
    Browse the repository at this point in the history

  8. rename Query resource dropdown endpoints

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    43366cb View commit details
    Browse the repository at this point in the history

  9. check access to dropdown query associations in one fugly query

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    527dc91 View commit details
    Browse the repository at this point in the history

  10. move ParameterizedQuery to models folder

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    4649e6d View commit details
    Browse the repository at this point in the history

  11. add dropdown association tests to query creation

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b5638af View commit details
    Browse the repository at this point in the history

  12. move group by query ids query into models.Query

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    91655ae View commit details
    Browse the repository at this point in the history

  13. use bound parameters for groups query

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b55d1c6 View commit details
    Browse the repository at this point in the history

  14. format groups query

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d2c3629 View commit details
    Browse the repository at this point in the history

  15. use new associatedDropdowns endpoint in dashboards

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    5ac0e13 View commit details
    Browse the repository at this point in the history

  16. pass down parameter and let it return dropdown options. Go Levko!

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    2d82996 View commit details
    Browse the repository at this point in the history

  17. change API to /api/queries/:id/dropdowns/:dropdown_id

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d52f87f View commit details
    Browse the repository at this point in the history

  18. split to 2 different dropdown endpoints and implement the second

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    83e911c View commit details
    Browse the repository at this point in the history

  19. use new /dropdowns endpoint in frontend

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    20f9b51 View commit details
    Browse the repository at this point in the history

  20. pass down parameter and let it return dropdown options. Go Levko!

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    1f39d04 View commit details
    Browse the repository at this point in the history

  21. fix bad rebase

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    6ad4424 View commit details
    Browse the repository at this point in the history

  22. add comment to clarify the purpose of checking the queryId

    Omer Lachish committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d2b95a7 View commit details
    Browse the repository at this point in the history