Use flask-talisman for handling backend response headers #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@rauchy Oh dang, I had missed your PR, apologies for the overlap 😬 |
arikfr
requested changes
Feb 19, 2019
jezdez
commented
Feb 22, 2019
arikfr
requested changes
Feb 25, 2019
jezdez
force-pushed
the
talisman
branch
2 times, most recently
from
d697222
to
bb26cee
Compare
|
@arikfr Is there anything needed to merge this? |
|
@arikfr Anything needed to merge this? |
arikfr
approved these changes
Mar 27, 2019
Time. |
1 task
jezdez
pushed a commit
that referenced
this pull request
Apr 17, 2019
## What type of PR is this? (check all applicable) - [x] Bug Fix ## Description Without this change the Help Drawer couldn't load content anymore. ## Related Tickets & Documents #3404
1 task
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
) * Normalize Flask initialization API use. * Use Flask-Talisman. * Enable HSTS when HTTPS is enforced. * More details about how CSP is formatted and write CSP directives as a string. * Use CSP frame-ancestors directive and not X-Frame-Options for embedable endpoints. * Add link to flask-talisman docs. * set remember_token cookie to be HTTP-Only and Secure * Reorganize secret key configuration to be forward thinking and backward compatible.
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
## What type of PR is this? (check all applicable) - [x] Bug Fix ## Description Without this change the Help Drawer couldn't load content anymore. ## Related Tickets & Documents getredash#3404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3060.
Refs #3044.
Refs mozilla#562.
Helps #2891. 🎉