-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more permissive when parameters are safe #3383
Commits on Jan 30, 2019
-
use the textless endpoint (/api/queries/:id/results) for pristine
queriest
Omer Lachish committedJan 30, 2019 Configuration menu - View commit details
-
Copy full SHA for cd2cee7 - Browse repository at this point
Copy the full SHA cd2cee7View commit details
Commits on Jan 31, 2019
-
reverse conditional. not not is making me the headaches.
Omer Lachish committedJan 31, 2019 Configuration menu - View commit details
-
Copy full SHA for e8ceeb7 - Browse repository at this point
Copy the full SHA e8ceeb7View commit details -
add ParameterizedQuery#is_safe with an inital naive implementation which
treats any query with a text parameter as not safe. This will be remedied later when DB drivers will handle these parameters.
Omer Lachish committedJan 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 06917ce - Browse repository at this point
Copy the full SHA 06917ceView commit details -
allow getting new query results even if user has only view permissions
to the data source (given that the query is safe)
Omer Lachish committedJan 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 31e2238 - Browse repository at this point
Copy the full SHA 31e2238View commit details
Commits on Feb 3, 2019
-
Merge branch 'master' into use-textless-endpoint-for-pristine-queries
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for c93ed69 - Browse repository at this point
Copy the full SHA c93ed69View commit details -
Merge branch 'use-textless-endpoint-for-pristine-queries' into be-mor…
…e-permissive-when-parameters-are-safe
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for d11e4e7 - Browse repository at this point
Copy the full SHA d11e4e7View commit details -
fix lint error - getDerivedStateFromProps should be placed after state
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for f858ca0 - Browse repository at this point
Copy the full SHA f858ca0View commit details -
Merge branch 'fix-time-ago-lint' into be-more-permissive-when-paramet…
…ers-are-safe
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 9bd2308 - Browse repository at this point
Copy the full SHA 9bd2308View commit details -
Merge branch 'master' into use-textless-endpoint-for-pristine-queries
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 04a1adf - Browse repository at this point
Copy the full SHA 04a1adfView commit details -
Revert "use the textless endpoint (/api/queries/:id/results) for pris…
…tine" This reverts commit cd2cee7.
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 9fc9fcb - Browse repository at this point
Copy the full SHA 9fc9fcbView commit details -
move execution preparation to a different function, which will be soon
reused
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for ab5eb8f - Browse repository at this point
Copy the full SHA ab5eb8fView commit details -
go to textless /api/queries/:id/results by default
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for df4e9e4 - Browse repository at this point
Copy the full SHA df4e9e4View commit details -
let the query view decide if text or textless endpoint is needed
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 49c9a68 - Browse repository at this point
Copy the full SHA 49c9a68View commit details -
Merge branch 'use-textless-endpoint-for-pristine-queries' into be-mor…
…e-permissive-when-parameters-are-safe
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 65e742c - Browse repository at this point
Copy the full SHA 65e742cView commit details -
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 8716626 - Browse repository at this point
Copy the full SHA 8716626View commit details -
allow safe queries to be executed in the UI even if the user has no
permission to execute and create new query results
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for d308a4d - Browse repository at this point
Copy the full SHA d308a4dView commit details -
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 8807e6a - Browse repository at this point
Copy the full SHA 8807e6aView commit details -
change
run_query
's signature to accept a ParameterizedQuery instead ofconstructing it inside
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 6c385c0 - Browse repository at this point
Copy the full SHA 6c385c0View commit details -
use dict#get instead of a None guard
Omer Lachish committedFeb 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 4682368 - Browse repository at this point
Copy the full SHA 4682368View commit details
Commits on Feb 5, 2019
-
use ParameterizedQuery in queries handler as well
Omer Lachish committedFeb 5, 2019 Configuration menu - View commit details
-
Copy full SHA for da45021 - Browse repository at this point
Copy the full SHA da45021View commit details -
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 5493f97 - Browse repository at this point
Copy the full SHA 5493f97View commit details
Commits on Feb 6, 2019
-
test that /queries/:id/results allows execution of safe queries even if
user has view_only permissions
Omer Lachish committedFeb 6, 2019 Configuration menu - View commit details
-
Copy full SHA for ae139fa - Browse repository at this point
Copy the full SHA ae139faView commit details -
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 6, 2019 Configuration menu - View commit details
-
Copy full SHA for c1b2d12 - Browse repository at this point
Copy the full SHA c1b2d12View commit details -
Omer Lachish committed
Feb 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 4518d12 - Browse repository at this point
Copy the full SHA 4518d12View commit details -
raise HTTP 400 when receiving invalid parameter values. Fixes #3394
Omer Lachish committedFeb 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 2202403 - Browse repository at this point
Copy the full SHA 2202403View commit details
Commits on Feb 10, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 926b679 - Browse repository at this point
Copy the full SHA 926b679View commit details
Commits on Feb 12, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 12, 2019 Configuration menu - View commit details
-
Copy full SHA for df62d8d - Browse repository at this point
Copy the full SHA df62d8dView commit details -
Omer Lachish committed
Feb 12, 2019 Configuration menu - View commit details
-
Copy full SHA for ca08af3 - Browse repository at this point
Copy the full SHA ca08af3View commit details -
avoid cyclic imports by importing only when needed
Omer Lachish committedFeb 12, 2019 Configuration menu - View commit details
-
Copy full SHA for c698a03 - Browse repository at this point
Copy the full SHA c698a03View commit details
Commits on Feb 17, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 97df888 - Browse repository at this point
Copy the full SHA 97df888View commit details -
verify that a ParameterizedQuery without any parameters is considered
safe
Omer Lachish committedFeb 17, 2019 Configuration menu - View commit details
-
Copy full SHA for fca4f1e - Browse repository at this point
Copy the full SHA fca4f1eView commit details
Commits on Feb 21, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish authoredFeb 21, 2019 Configuration menu - View commit details
-
Copy full SHA for 70ea5b9 - Browse repository at this point
Copy the full SHA 70ea5b9View commit details
Commits on Feb 22, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish authoredFeb 22, 2019 Configuration menu - View commit details
-
Copy full SHA for c66cfab - Browse repository at this point
Copy the full SHA c66cfabView commit details
Commits on Feb 24, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 24, 2019 Configuration menu - View commit details
-
Copy full SHA for dc3f221 - Browse repository at this point
Copy the full SHA dc3f221View commit details -
Merge branch 'be-more-permissive-when-parameters-are-safe' of github.…
…com:getredash/redash into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 8027ed2 - Browse repository at this point
Copy the full SHA 8027ed2View commit details
Commits on Feb 26, 2019
-
Merge branch 'master' into be-more-permissive-when-parameters-are-safe
Omer Lachish committedFeb 26, 2019 Configuration menu - View commit details
-
Copy full SHA for 65b6b2a - Browse repository at this point
Copy the full SHA 65b6b2aView commit details -
introduce query.parameter_schema
Omer Lachish committedFeb 26, 2019 Configuration menu - View commit details
-
Copy full SHA for 5bdab05 - Browse repository at this point
Copy the full SHA 5bdab05View commit details -
encapsulate ParameterizedQuery creation inside Query
Omer Lachish committedFeb 26, 2019 Configuration menu - View commit details
-
Copy full SHA for 9d5e231 - Browse repository at this point
Copy the full SHA 9d5e231View commit details