Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget params: Date/Date range value empty in static param input #3357

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Widget params: Date/Date range value empty in static param input #3357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c284db
getredash/redash#3355 Widget params: Date/Date range value empty in s…
kravets-levko Jan 28, 2019
c938d33
Merge branch 'master' into bug/widget-param-static-value
kravets-levko Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/app/components/ParameterMappingInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint react/no-multi-comp: 0 */

import { extend, map, includes, findIndex, find, fromPairs, isNull, isUndefined } from 'lodash';
import { extend, map, includes, findIndex, find, fromPairs } from 'lodash';
import React from 'react';
import PropTypes from 'prop-types';
import Select from 'antd/lib/select';
Expand Down Expand Up @@ -163,7 +163,7 @@ export class ParameterMappingInput extends React.Component {
<ParameterValueInput
className="w-100"
type={mapping.param.type}
value={isUndefined(mapping.value) || isNull(mapping.value) ? mapping.param.normalizedValue : mapping.value}
value={mapping.param.normalizedValue}
enumOptions={mapping.param.enumOptions}
queryId={mapping.param.queryId}
onSelect={value => this.updateParamMapping(mapping, { value })}
Expand Down