Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Angular services to CommonJS-style and use them in React components instead of injecting #3331

Merged
merged 10 commits into from
Jan 24, 2019
Merged

Convert Angular services to CommonJS-style and use them in React components instead of injecting #3331

merged 10 commits into from
Jan 24, 2019

Commits on Jan 24, 2019

  1. Refine Auth service: remove dead code and fix race condition

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    fa7c237 View commit details
    Browse the repository at this point in the history

  2. Export services in CommonJS style

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    dd8968f View commit details
    Browse the repository at this point in the history

  3. Refine Users, Events and OfflineListener services

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    9d11662 View commit details
    Browse the repository at this point in the history

  4. Refactor Notifications service - rewrite to CommonJS

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    9951942 View commit details
    Browse the repository at this point in the history

  5. Replace Angular service injection with imports in React components

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1303b04 View commit details
    Browse the repository at this point in the history

  6. Fix Footer tests

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1d421dd View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into feature/react-ng-services

    @kravets-levko
    kravets-levko authored Jan 24, 2019
    Configuration menu
    Copy the full SHA
    badbf60 View commit details
    Browse the repository at this point in the history

  8. Events service -> recordEvent function

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ac83dd9 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/react-ng-services' of github.com:kravets-levko/… 

    …redash into feature/react-ng-services
    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    58949e0 View commit details
    Browse the repository at this point in the history

  10. CR1

    @kravets-levko
    kravets-levko committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7b0bdc0 View commit details
    Browse the repository at this point in the history