add thrift version 0.9.3 to requirements #3303
Conversation
|
We would appreciate it if you could provide us with more info about this issue/pr! |
request-info
bot
added
the
Needs More Information
ghost
added
the
|
Continue of PR #2410 |
arikfr
added
PR: unreviewed
and removed
in progress
Needs More Information
|
The reason it wasn't merged until now is that we don't have a way to know the impact of pinning the Thrift version on all the data sources that use it. Until we have better test coverage (#3807) for our query runners or someone from the community can test it with the different ones that use Thrift, we won't be able to merge it :-( |
|
Hi, (This is a template message, but I mean every word of it. Also you're welcome to reply) Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇 In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-( I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen. Thanks. |
No description provided.