Feature: Refresh schedule - code optimizations #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
arikfr
approved these changes
Jan 3, 2019
ranbena
force-pushed
the
feature/refresh-schedule/code-opt
branch
from
da6a596
to
ff00b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a PR batch to finalize the refresh-schedule feature.
After merging all changes in to
feature/refresh-schedule/emtwoit should be merged intomaster.What changed
This commit introduces no change in style or functionality.
Prepares code for upcoming changes.
Optimizations
intervalToSecondsto@/filterssince the corresponding method resides there.momentandlodash,🤘