Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP dynamic Bind DN #3226

Closed
wants to merge 7 commits into from
Closed

LDAP dynamic Bind DN #3226

wants to merge 7 commits into from

Conversation

2union
Copy link

@2union 2union commented Dec 28, 2018

Allows to take username and password to Bind DN from form. Username should be masked in parameter LDAP_BIND_DN.
e.g.
REDASH_LDAP_BIND_DN_DYNAMIC: 1
REDASH_LDAP_BIND_DN: "%(username)s@kontur"

@ghost ghost added the in progress label Dec 28, 2018
@2union
Copy link
Author

2union commented Jan 22, 2019

Whats different in percy/redash? It's looks equal on screenshots.

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

@arikfr arikfr closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants