Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choropleth customize #3154

Merged
merged 8 commits into from
May 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions client/app/visualizations/choropleth/choropleth-editor.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,23 @@
<div class="row">
<div class="col-xs-6">
<div class="form-group">
<label>Country code column</label>
<label>Map Type</label>
<select ng-options="key as value for (key, value) in $ctrl.mapTypes"
ng-model="$ctrl.options.mapType" class="form-control"></select>
</div>
</div>
</div>
<div class="row">
<div class="col-xs-6">
<div class="form-group">
<label>Key column</label>
<select ng-options="col.name as col.name for col in $ctrl.data.columns"
ng-model="$ctrl.options.countryCodeColumn" class="form-control"></select>
</div>
</div>
<div class="col-xs-6">
<div class="form-group">
<label>Country code type</label>
<label>Key type</label>
<select ng-options="key as value for (key, value) in $ctrl.countryCodeTypes"
ng-model="$ctrl.options.countryCodeType" class="form-control"></select>
</div>
Expand Down
101 changes: 78 additions & 23 deletions client/app/visualizations/choropleth/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ import template from './choropleth.html';
import editorTemplate from './choropleth-editor.html';

import countriesDataUrl from './countries.geo.json';
import subdivJapanDataUrl from './japan.prefectures.geo.json';

export const ChoroplethPalette = _.extend({}, AdditionalColors, ColorPalette);

const DEFAULT_OPTIONS = {
mapType: 'countries',
countryCodeColumn: '',
countryCodeType: 'iso_a3',
valueColumn: '',
Expand Down Expand Up @@ -109,6 +111,16 @@ const ChoroplethRenderer = {
}
};

const getDataUrl = (type) => {
switch (type) {
case 'countries': return countriesDataUrl;
case 'subdiv_japan': return subdivJapanDataUrl;
default: return '';
}
};

let dataUrl = getDataUrl(this.options.mapType);

const render = () => {
if (map) {
map.remove();
Expand Down Expand Up @@ -154,7 +166,7 @@ const ChoroplethRenderer = {
layer.bindTooltip($sanitize(formatSimpleTemplate(
this.options.tooltip.template,
featureData,
)));
)), { sticky: true });
}

if (this.options.popup.enabled) {
Expand Down Expand Up @@ -205,12 +217,17 @@ const ChoroplethRenderer = {
updateBounds({ disableAnimation: true });
};

loadCountriesData($http, countriesDataUrl).then((data) => {
if (_.isObject(data)) {
countriesData = data;
render();
}
});
const load = () => {
loadCountriesData($http, dataUrl).then((data) => {
if (_.isObject(data)) {
countriesData = data;
render();
}
});
};

load();


$scope.handleResize = _.debounce(() => {
if (map) {
Expand All @@ -220,8 +237,12 @@ const ChoroplethRenderer = {
}, 50);

$scope.$watch('$ctrl.data', render);
$scope.$watch(() => _.omit(this.options, 'bounds'), render, true);
$scope.$watch(() => _.omit(this.options, 'bounds', 'mapType'), render, true);
$scope.$watch('$ctrl.options.bounds', updateBounds, true);
$scope.$watch('$ctrl.options.mapType', () => {
dataUrl = getDataUrl(this.options.mapType);
load();
}, true);
},
};

Expand All @@ -240,6 +261,11 @@ const ChoroplethEditor = {

this.colors = ChoroplethPalette;

this.mapTypes = {
countries: 'Countries',
subdiv_japan: 'Japan/Prefectures',
};

this.clusteringModes = {
q: 'quantile',
e: 'equidistant',
Expand All @@ -253,35 +279,64 @@ const ChoroplethEditor = {
'bottom-right': 'bottom / right',
};

this.countryCodeTypes = {
name: 'Short name',
name_long: 'Full name',
abbrev: 'Abbreviated name',
iso_a2: 'ISO code (2 letters)',
iso_a3: 'ISO code (3 letters)',
iso_n3: 'ISO code (3 digits)',
};
this.countryCodeTypes = {};

this.templateHint = `
this.templateHintFormatter = propDescription => `
<div class="p-b-5">All query result columns can be referenced using <code>{{ column_name }}</code> syntax.</div>
<div class="p-b-5">Use special names to access additional properties:</div>
<div><code>{{ @@value }}</code> formatted value;</div>
<div><code>{{ @@name }}</code> short country name;</div>
<div><code>{{ @@name_long }}</code> full country name;</div>
<div><code>{{ @@abbrev }}</code> abbreviated country name;</div>
<div><code>{{ @@iso_a2 }}</code> two-letter ISO country code;</div>
<div><code>{{ @@iso_a3 }}</code> three-letter ISO country code;</div>
<div><code>{{ @@iso_n3 }}</code> three-digit ISO country code.</div>
${propDescription}
<div class="p-t-5">This syntax is applicable to tooltip and popup templates.</div>
`;

const updateCountryCodeType = () => {
this.options.countryCodeType = inferCountryCodeType(
this.options.mapType,
this.data ? this.data.rows : [],
this.options.countryCodeColumn,
) || this.options.countryCodeType;
};

const populateCountryCodeTypes = () => {
let propDescription = '';
switch (this.options.mapType) {
case 'subdiv_japan':
propDescription = `
<div><code>{{ @@name }}</code> Prefecture name in English;</div>
<div><code>{{ @@name_local }}</code> Prefecture name in Kanji;</div>
<div><code>{{ @@iso_3166_2 }}</code> five-letter ISO subdivision code (JP-xx);</div>
`;
this.countryCodeTypes = {
name: 'Name',
name_local: 'Name (local)',
iso_3166_2: 'ISO-3166-2',
};
break;
case 'countries':
propDescription = `
<div><code>{{ @@name }}</code> short country name;</div>
<div><code>{{ @@name_long }}</code> full country name;</div>
<div><code>{{ @@abbrev }}</code> abbreviated country name;</div>
<div><code>{{ @@iso_a2 }}</code> two-letter ISO country code;</div>
<div><code>{{ @@iso_a3 }}</code> three-letter ISO country code;</div>
<div><code>{{ @@iso_n3 }}</code> three-digit ISO country code.</div>
`;
this.countryCodeTypes = {
name: 'Short name',
name_long: 'Full name',
abbrev: 'Abbreviated name',
iso_a2: 'ISO code (2 letters)',
iso_a3: 'ISO code (3 letters)',
iso_n3: 'ISO code (3 digits)',
};
break;
default:
this.countryCodeTypes = {};
}
this.templateHint = this.templateHintFormatter(propDescription);
};

$scope.$watch('$ctrl.options.mapType', populateCountryCodeTypes);
$scope.$watch('$ctrl.options.countryCodeColumn', updateCountryCodeType);
$scope.$watch('$ctrl.data', updateCountryCodeType);

Expand Down
Loading