Get all tables in the BigQuery #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI failed tests will succeed if #2457 is merged. |
kyoshidajp
force-pushed
the
get_all_tables_in_bq
branch
from
c9a7967
to
ffa7018
Compare
kyoshidajp
force-pushed
the
get_all_tables_in_bq
branch
from
5adb8ac
to
3021c7c
Compare
|
I believe this fix the issue. Could anyone review this PR? |
|
Hey @kyoshidajp! Sorry for the delay. We're a bit behind on issues, especially because of the v4 release. We'll get to this when we have some free time. |
|
Hi @RichardLitt. Thank you for your reply. I got it. |
|
Thank you, @kyoshidajp! Apologies for the long wait. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using BigQuery data source, all tables are not listed in the query edit page.
Thre result will be cached, so there will no be a problem.
Changes
Add
pageTokenparameter into the getting tables request if result data hasnextPageTokenfield.