Add a Redash extension system based on Python entrypoints. #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
force-pushed
the
redash-extensions
branch
from
9b29708
to
9c02fa0
Compare
This is along the lines of what Flask does for CLI plugins: http://flask.pocoo.org/docs/0.12/cli/#cli-plugins The API allows specifying Python callbacks that receive the Redash Flask app as the only argument and allow extending the Redash process with the usual Flask API as needed. This does not cover front-end specific extensions (yet).
jezdez
force-pushed
the
redash-extensions
branch
from
9c02fa0
to
6b41644
Compare
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is along the lines of what Flask does for CLI plugins:
http://flask.pocoo.org/docs/0.12/cli/#cli-plugins
The API allows specifying Python callbacks that receive the
Redash Flask app as the only argument and allow extending
the Redash process with the usual Flask API as needed. This
does not cover front-end specific extensions (yet).
This is a backport from mozilla#348
that should make our lives at Mozilla easier and maybe lead to
a more extensible Redash code base.
A suggested path forward would be investigating additional
extension points for adding front-end components/pages and
query runners (e.g. the Cassandra query runner which slows
build time down a lot).