Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add an unarchive dashboard button #2180

Closed

Conversation

kyoshidajp
Copy link
Member

Fix #982.

It would be easy to restore without directly updating DB ☺️

Screenshot

Replaced "archived" label to "Unarchive" button.
unarchive_button

Confirm modal:
unarchive_dialog

@kyoshidajp
Copy link
Member Author

Moved an unarchive button to the button group.

Actually, other buttons are not displayed when a dashboard is archived. So, I changed that only unarchive button is shown.

unarchive_dashbord_inside_button_group

@kyoshidajp
Copy link
Member Author

@arikfr Could you review this? I hope this feature helps many users.

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an "unarchive" button on archived dashboards
3 participants