[Datasources] Add: Add query runner for Yandex ClickHouse #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
requested changes
Nov 22, 2016
| return schema.values() | ||
|
|
||
| def _send_query(self, data, stream=False): | ||
| url = 'http://{host}:{port}'.format(host=self.configuration['host'], port=self.configuration['port']) |
There was a problem hiding this comment.
http and not https? why not let the user specify the full url instead of host/port pair?
| return {'columns': columns, 'rows': result['data']} | ||
|
|
||
| def run_query(self, query, user): | ||
| logger.info("Clickhouse is about to execute query: %s", query) |
There was a problem hiding this comment.
Let's change this to logger.debug.
| q = self._clickhouse_query(query) | ||
| data = json.dumps(q, cls=JSONEncoder) | ||
| error = None | ||
| except Exception as exc: |
There was a problem hiding this comment.
If we just return the exception as the error value, we can let it bubble up and handle it there.
| logger = logging.getLogger(__name__) | ||
|
|
||
| try: | ||
| import requests |
There was a problem hiding this comment.
No need to wrap this in try/except. requests is a direct dependency of the project.
arikfr
changed the title
arikfr
reviewed
Nov 23, 2016
| data = None | ||
| error = str(exc) | ||
| logging.exception(e) | ||
| error = str(e) |
There was a problem hiding this comment.
Btw, it's possible the exception might have some unicode characters, no? (like fragments of the query) So maybe better to use unicode here.
There was a problem hiding this comment.
of course. changed.
arikfr
changed the title
arikfr
approved these changes
Nov 24, 2016
|
Thanks! |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
[Datasources] Add: Add query runner for Yandex ClickHouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query runner for this database: https://clickhouse.yandex
It works via HTTP interface and gets answer as JSON: https://clickhouse.yandex/reference_en.html#JSON