Change: correctly propagate ElasticSearch errors to the UI #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for doing some house keeping there as well! The ElasticSearch data source definitely needs some more love. |
|
Just noticed that I've mixed logging and logger usage (always do that =). I'll fix this tomorrow and update the PR.
|
Handle and correctly print various errors which we're being obscured as "Unable to serialise JSON" errors. Requests' exceptions also have non-json serializable characters, and so have to be converted to a safer format.
|
Ok, should be good to go. |
arikfr
changed the title
arikfr
added a commit
that referenced
this pull request
Nov 25, 2016
Add missing error check from #1402
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Change: correctly propagate ElasticSearch errors to the UI
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Add missing error check from getredash#1402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All erronous ES queries have been displaying an error stating the JSON could not be decoded, regardless of the actual error (HTTP, syntax, auth, etc).
This modification ensures any request error is propagated back.
It seems that the main issue was requests errors being non-json-serializable due to the usage of both " and ' characters.
The abstraction of the
_get_mappingfunction also made it difficult to get the root error instead of just the exception, this has been modified to be similar torun_queryand now returns a tuple of(mappings, error).