Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with change tracking and version counter (dashboard, queries) #1550

Open
2 tasks
arikfr opened this issue Jan 26, 2017 · 2 comments
Open
2 tasks

Fix issues with change tracking and version counter (dashboard, queries) #1550

arikfr opened this issue Jan 26, 2017 · 2 comments
Milestone
Next

Comments

@arikfr
Copy link
Member

arikfr commented Jan 26, 2017

Since the rewrite to use SQLAlchemy we never fully implemented the change tracking functionality. Also in #1549 I broke it further to fix a bug SQLA's version tracking introduced.

  • Call change logging in relevant API calls.
  • Manually increment Query's version in relevant API calls.
arikfr added a commit that referenced this issue Jan 26, 2017
@arikfr
Disable query version check in test (#1550)
6cf1c1c
@arikfr
Copy link
Member Author

arikfr commented Jan 26, 2017

6cf1c1c

@rafrombrc rafrombrc mentioned this issue Jan 27, 2017
Closed
washort pushed a commit to washort/redash that referenced this issue Mar 14, 2017
clean up change tracking (re getredash#1550)
8bf5c22
@alison985
Copy link
Contributor

@arikfr The tests have been added back in tests/models/test_changes.py:

        self.assertEqual(change.object_version, 2)
        self.assertEqual(change.object_version, obj.version)

Is this complete? Or could you give more information on it?

@arikfr arikfr added this to the v7.0.0 milestone Dec 10, 2018
@arikfr arikfr modified the milestones: v7.0.0, Next Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@arikfr @alison985