Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong sort for Date column #1457

Closed
denisov-vlad opened this issue Dec 6, 2016 · 2 comments
Closed

Wrong sort for Date column #1457

denisov-vlad opened this issue Dec 6, 2016 · 2 comments
Labels
Bug Frontend
Milestone
v1.0.0

Comments

@denisov-vlad
Copy link
Member

It happens if sort by date column with UI.

Screenshot shows everything.

2016-12-06 14 37 07
@WesleyBatista
Copy link
Contributor

WesleyBatista commented Dec 6, 2016 •
edited
Loading

Sorry, didn't get the problem.

It seems to be a descending sort.
2016-12-06 is greater than 2016-11-07, right?

@denisov-vlad
Copy link
Member Author

@WesleyBatista but it's ascending sort. Looks like it sorts strings 'DD/MM/YYYY' but not dates 'YYYY-MM-DD'

@arikfr arikfr added this to the v1.0.0 milestone Dec 11, 2016
@arikfr arikfr closed this as completed in 40b8200 Dec 23, 2016
arikfr added a commit that referenced this issue Dec 23, 2016
@arikfr
Merge pull request #1484 from getredash/v1fixes
e0a010f 
Fix #1457: sort was using the string value
dairyo pushed a commit to KiiCorp/redash that referenced this issue Mar 1, 2019
@arikfr
Merge pull request getredash#1484 from getredash/v1fixes
13af543 
Fix getredash#1457: sort was using the string value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Frontend
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@arikfr @WesleyBatista @denisov-vlad