Skip to content

Commit

Permalink
Fail query task properly even if error message is empty (#3499)
Browse files Browse the repository at this point in the history
  • Loading branch information
Allen Short authored and arikfr committed Mar 27, 2019
1 parent 71afc99 commit d5494cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion redash/tasks/queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def run(self):

_unlock(self.query_hash, self.data_source.id)

if error:
if error is not None and data is None:
result = QueryExecutionError(error)
if self.scheduled_query is not None:
self.scheduled_query = models.db.session.merge(self.scheduled_query, load=False)
Expand Down

0 comments on commit d5494cf

Please sign in to comment.