Separated Alert to View / Edit / New page components (#4183)

* Separated Alert to View / Edit / New page components * Moved query result loader into <Query /> * Added missing Query prop * No reload for edit / view / new state changes * Added warn and tooltip when non-editable * Rebased
getredash · Oct 7, 2019 · be404a4 · be404a4
1 parent 8f378ed
commit be404a4
Show file tree

Hide file tree

Showing 10 changed files with 576 additions and 286 deletions.
diff --git a/client/app/assets/less/inc/alert.less b/client/app/assets/less/inc/alert.less
@@ -2,7 +2,7 @@
     flex-grow: 1;
 
     input {
-        margin: -0.2em 0; // 
+        margin: -0.2em 0;
         width: 100%;
         min-width: 170px;
     }

diff --git a/client/app/components/proptypes.js b/client/app/components/proptypes.js
@@ -126,7 +126,7 @@ export const Alert = PropTypes.shape({
   rearm: PropTypes.number,
   state: PropTypes.oneOf(['ok', 'triggered', 'unknown']),
   user: UserProfile,
-  query: Query.isRequired,
+  query: Query,
   options: PropTypes.shape({
     column: PropTypes.string,
     op: PropTypes.string,