Add user/pass authentication support for Druid (#4315)

* Add support for configuring a Username/Password for the connection to Druid * Bump pydruid version for username/password support * Deal with missing/empty configuration parameters
getredash · Dec 5, 2019 · 3494e21 · 3494e21
1 parent 15e8b88
commit 3494e21
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/redash/query_runner/druid.py b/redash/query_runner/druid.py
@@ -34,10 +34,17 @@ def configuration_schema(cls):
                 "scheme": {
                     "type": "string",
                     "default": "http"
+                },
+                "user": {
+                    "type": "string"
+                },
+                "password": {
+                    "type": "string"
                 }
             },
-            "order": ['scheme', 'host', 'port'],
-            "required": ['host']
+            "order": ['scheme', 'host', 'port', 'user', 'password'],
+            "required": ['host'],
+            "secret": ['password']
         }
 
     @classmethod
@@ -48,7 +55,9 @@ def run_query(self, query, user):
         connection = connect(host=self.configuration['host'],
                              port=self.configuration['port'],
                              path='/druid/v2/sql/',
-                             scheme=self.configuration['scheme'])
+                             scheme=(self.configuration.get('scheme') or 'http'),
+                             user=(self.configuration.get('user') or None),
+                             password=(self.configuration.get('password') or None))
 
         cursor = connection.cursor()
 

diff --git a/requirements_all_ds.txt b/requirements_all_ds.txt
@@ -24,7 +24,7 @@ PyAthena>=1.5.0
 pymapd==0.16.0
 qds-sdk>=1.9.6
 ibm-db>=2.0.9
-pydruid==0.5.5
+pydruid==0.5.7
 requests_aws_sign==0.1.5
 snowflake-connector-python==2.0.3
 phoenixdb==0.7