CR1

getredash · Jul 3, 2019 · 339122f · 339122f
1 parent 20bd101
commit 339122f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/client/app/visualizations/box-plot/Renderer.jsx b/client/app/visualizations/box-plot/Renderer.jsx
@@ -163,9 +163,10 @@ export default function Renderer({ data, options }) {
   useEffect(() => {
     if (container) {
       render(container, data, options);
-      return resizeObserver(container, () => {
+      const unwatch = resizeObserver(container, () => {
         render(container, data, options);
       });
+      return unwatch;
     }
   }, [container, data, options]);
 

diff --git a/client/app/visualizations/box-plot/renderer.less b/client/app/visualizations/box-plot/renderer.less
@@ -1,4 +1,4 @@
 .box-plot-deprecated-visualization-container {
   overflow: hidden;
-  height: 400px;
+  height: 500px;
 }
diff --git a/client/app/visualizations/word-cloud/Renderer.jsx b/client/app/visualizations/word-cloud/Renderer.jsx
@@ -157,12 +157,13 @@ export default function Renderer({ data, options }) {
 
   useEffect(() => {
     if (container) {
-      return resizeObserver(container, () => {
+      const unwatch = resizeObserver(container, () => {
         const svg = container.querySelector('svg');
         if (svg) {
           scaleElement(svg, container);
         }
       });
+      return unwatch;
     }
   }, [container]);
 

diff --git a/client/cypress/integration/visualizations/box_plot_spec.js b/client/cypress/integration/visualizations/box_plot_spec.js
@@ -58,11 +58,11 @@ describe('Box Plot', () => {
       'BoxPlot.YAxisLabel': 'Y Axis',
     });
 
-    // Wait for proper initialization of visualization
-    cy.wait(500); // eslint-disable-line cypress/no-unnecessary-waiting
-
     cy.getByTestId('VisualizationPreview').find('svg').should('exist');
 
-    cy.percySnapshot('Visualizations - Box Plot');
+    cy.viewport(1280, 1024);
+    cy.wait(500); // eslint-disable-line cypress/no-unnecessary-waiting
+    cy.screenshot();
+    cy.percySnapshot('Visualizations - Box Plot', { widths: [1280] });
   });
 });