Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Dataset with Entity List #1651

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Sep 13, 2023

Do not merge until Central v2023.4 and pyxform 12.1.2 are released!

Closes getodk/central#466

I made a few cosmetic changes as I went, I don't think any should be controversial! @matthew-white and @ktuite, I'll let you two decide who most wants to review this. @ktuite at some point we should talk about whether we should consider updating your video. It's still very relevant! But the change in terminology is a bit distracting.

@lognaturel lognaturel marked this pull request as draft September 13, 2023 23:18
@lognaturel lognaturel force-pushed the entity-lists branch 4 times, most recently from adea287 to 8633576 Compare September 14, 2023 17:14
@lognaturel lognaturel marked this pull request as ready for review September 14, 2023 17:28

Add a new ``entities`` sheet to your XLSForm. This is where you will specify your Dataset’s name, under ``dataset``.
Add a new ``entities`` sheet to your XLSForm. This is where you will specify your Entity List name, under ``list_name``.
Copy link
Member Author

@lognaturel lognaturel Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktuite I'm specifically interested in your thoughts on list_name since you've made educational materials for all this. Do you think it's helpful or harmful that it's the same as the column header to specify the list that a choice is in from the choices sheet?

I thought it was helpful but I'm questioning that a little bit because the usage is different. On the choices tab, we're explicitly stating the list that a concrete item belongs in. Here, we're generally declaring the list that abstract entities will be created in. Maybe that's similar enough?

We could consider list though that might be even more confusing. We could also try something different like destination or target_list. @yanokwa did not like any of those when I ran them by him.

I still like list_name the best but I do want to get at least another sanity check now that I've had these thoughts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think list_name is okay. the entities tab has such a different purpose and shape than the choices tab that i think it's ok for the column header to be the same but have slightly different meanings within the different context. this happens with label, too. having some other word that is slightly different yet also isn't a perfect fit seems like it would be more confusing

@matthew-white
Copy link
Member

I think @ktuite will be taking a look at this PR. Thank you, @ktuite!

and pyxform 12.1.2

Are we planning to ship a pyxform change with Central .4? It might be nice for what's in the docs to match the pyxform that we ship with Central.

@matthew-white matthew-white removed their request for review September 14, 2023 19:54
@lognaturel
Copy link
Member Author

Are we planning to ship a pyxform change with Central .4?

Yes and I just reopened the corresponding issue. Realized that as I worked on these docs yesterday.

Copy link
Member

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm liking this dataset -> "entity list" change more and more because now I can tell that pre-entity-era "datasets", like "form datasets" are different.

In central-intro.rst, should this line be updated or clarified?

* Server-managed datasets for registration/follow-up workflows"

Maybe "server-managed datasets (entity lists)..."?

@@ -65,67 +75,64 @@ In this Quick Start, you will upload two Forms we have already authored for you:
First, let's prepare the Forms for use with Central.

1. Create a new Project, if you can. It can be easier to see what's going on without other Forms in the way.
2. Upload the `Tree registration Form <https://docs.google.com/spreadsheets/d/1xboXBJhIUlhs0wlblCxcQ3DB5Ubpx2AxLDuaXh_JYyw/edit#gid=2050654322>`_. Notice how it has seen from the Form definition that the Form creates Entities in a Dataset, and populates three Entity Properties.
3. Publish the Form. As the dialog says, this action creates the ``trees`` Dataset within the Project you created.
2. Upload the `Tree registration Form <https://docs.google.com/spreadsheets/d/1xboXBJhIUlhs0wlblCxcQ3DB5Ubpx2AxLDuaXh_JYyw/edit#gid=2050654322>`_. Notice how Central knows from the Form definition that the Form creates Entities in an Entity List, and populates three Entity Properties.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update "dataset" --> "list_name" in this demo form.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes, thank you! I'll set myself a reminder to do that when we merge.

@lognaturel
Copy link
Member Author

In central-intro.rst, should this line be updated or clarified?

Good catch! Fixed.

@lognaturel lognaturel merged commit 02befd2 into getodk:master Sep 25, 2023
1 check passed
@lognaturel lognaturel deleted the entity-lists branch September 25, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Dataset" to "Entity List"
3 participants