-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated licenses and dependencies #786 Done #792
Conversation
@krishnarai30 Thanks! The intent was just to update the licenses but updating the libraries is a good idea as well. Can you please describe what you did to be confident that the version changes don't affect behavior? |
@lognaturel Also checking which dependency is still useful or not, I referred to this question on StackOverflow http://stackoverflow.com/questions/19379517/how-to-find-remove-unused-dependencies-in-gradle further, I removed each of dependency one by one and manually checked the behavior of the application in runtime on my phone one plus 3 with android 7.0, for producing some bugs it might produce. Also, this will bring us closer to a step of introducing new User experince we all are excited to work upon. |
As discussed in #478, updating play services will require all the users to update the google play service in their devices to the latest version. This would require 70~80 MB upgrade which is not at all needed at the current moment. |
@shobhitagarwal1612 Also the moment for UI upgrade is here thus no better time to upgrade the play services version. Further 70-80 mb upgrade aren't any relevant data charges in any of the country in the world thus upgrading cost might also not affect the minimal user of the application. |
@shobhitagarwal1612 Do you know how to tell definitively what Play Services version will be required? I was surprised to notice that this doesn't actually change the Google Play Services version in the @krishnarai30 Many users are actually in places with very slow connections and high data charges. 70mb-80mb can be very significant in those conditions. |
Oh, I'm sorry, it looks like I hadn't refreshed properly! Yes, it does change it from @krishnarai30 Please take out the updates that would force a Play Services upgrade. |
@lognaturel I would remove play services update as you say but please reconsider once as it wont be forced by collect to update those services. |
I guess it means that the version of the Google Play Services required to run the application should be atleast this much |
@shobhitagarwal1612 |
@krishnarai30 May I suggest that you read a bit about ODK and its target uses? Many users are almost entirely offline, in fact, many deployments are done through APKs that bypass the Play Store. Old devices that may not have the option of updating Play Services are common. Certainly we can make the update once we leverage features that require it but we should aim to delay it as much as possible. |
This reverts commit 047db62.
@lognaturel |
Thank you, @krishnarai30, and welcome to the project! 🎉 |
This PR has updated all the dependencies used in the application and new licenses have been added and previous ones have been deleted.
@lognaturel please review this.
Issue #786 is solved herewithin.