Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra state and use Android APIs in activities with checkable lists #303 #480

Merged
merged 29 commits into from
Mar 2, 2017
Merged

Remove extra state and use Android APIs in activities with checkable lists #303 #480

merged 29 commits into from
Mar 2, 2017

Commits on Feb 27, 2017

  1. Configuration menu
    Copy the full SHA
    3ae773d View commit details
    Browse the repository at this point in the history
  2. Move preference keys to a new class, PreferenceKeys. This shortens Pr…

    …eferencesActivity, and removes dependencies on it from those classes which only need the key strings.
    dcbriccetti committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    8ed494b View commit details
    Browse the repository at this point in the history
  3. Encapsulate the findPreference deprecation warning and allow shorter …

    …code to get ListPreferences
    dcbriccetti committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    fff4cfb View commit details
    Browse the repository at this point in the history
  4. Move preference keys to a new class, PreferenceKeys. This shortens Pr…

    …eferencesActivity, and removes dependencies on it from those classes which only need the key strings. Inline a variable.
    dcbriccetti committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    b3ded2d View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'remotes/upstream/master'

    # Conflicts:
    #	collect_app/src/main/java/org/odk/collect/android/preferences/PreferencesActivity.java
    dcbriccetti committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    b7fc893 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'remotes/upstream/master'

    # Conflicts:
    #	collect_app/src/main/java/org/odk/collect/android/preferences/PreferencesActivity.java
    dcbriccetti committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    a2ddbd6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e72bd39 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2017

  1. PreferencesActivity: Remove duplicate code. Organize. Improve readabi…

    …lity.
    
    AdminPreferencesActivity: Move keys to new AdminKeys class.
    dcbriccetti committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    796970c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6227962 View commit details
    Browse the repository at this point in the history
  3. Fix comments.

    dcbriccetti committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    31c92c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c0574a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e28bdb8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7dd22ac View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2017

  1. Further improve the automatic removal of general preferences based on…

    … the values of the admin preferences. Clean up more code.
    dcbriccetti committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    5adc77f View commit details
    Browse the repository at this point in the history
  2. Inline a field

    dcbriccetti committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    71e149f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2563f9d View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'upstream/master' into 303-activities-ch…

    …eckable-lists
    
    # Conflicts:
    #	collect_app/src/main/java/org/odk/collect/android/activities/InstanceUploaderList.java
    dcbriccetti committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    9a2ed90 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'upstream/master' into 303-activities-ch…

    …eckable-lists
    
    # Conflicts:
    #	collect_app/src/main/java/org/odk/collect/android/activities/InstanceUploaderList.java
    dcbriccetti committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    4c3b602 View commit details
    Browse the repository at this point in the history
  6. Remove extra state and use Android APIs in activities with checkable …

    …lists #303.
    
    Create a common superclass for these list classes. This could join with or replace ListViewUtils later.
    dcbriccetti committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    7ce7075 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2017

  1. Remove extra state and use Android APIs in activities with checkable …

    …lists #303.
    
    This completes most of the work. More testing is needed.
    dcbriccetti committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    ed53604 View commit details
    Browse the repository at this point in the history
  2. Discard checkbox checked state saving and restoring code, but keep th…

    …at for buttons’ enabled state, which is not saved automatically by Android.
    dcbriccetti committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    f4e3446 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e277ac5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7020f7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce5ffd6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3250e22 View commit details
    Browse the repository at this point in the history
  7. Change ++i to i++.

    dcbriccetti committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    ba4e5f8 View commit details
    Browse the repository at this point in the history
  8. Restore the enabled state of the Select/Clear All button on configura…

    …tion change (orientation).
    dcbriccetti committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    2865e1d View commit details
    Browse the repository at this point in the history
  9. Remove unused import

    dcbriccetti committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    bd27bd4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cd04af1 View commit details
    Browse the repository at this point in the history