-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove option to save geotrace as polygon #3078
Conversation
a8756e3
to
b102546
Compare
@@ -29,6 +27,8 @@ | |||
import android.widget.Spinner; | |||
import android.widget.TextView; | |||
|
|||
import androidx.annotation.VisibleForTesting; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got reordered automatically by Android Studio because it went from an android.
package to an androidx.
package.
b102546
to
bbbdd12
Compare
bbbdd12
to
fb5e8c4
Compare
Tested with success
Verified also:
Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 @opendatakit-bot unlabel "needs testing" |
@opendatakit-bot label "behavior verified" |
Closes #1028, at long last. This simply removes the dialog which @zestyping has nicely isolated and commented as being destined for removal.
The meaningful changes are all in GeoPolyActivity. The other changes are for removing unused resources.
What has been done to verify that this works as intended?
From the All Widgets form, launched geotrace and verified that:
From the All Widgets form, launched geoshape and verified that:
Why is this the best possible solution? Were any other approaches considered?
This is a surgical removal so there aren't any real alternatives.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This fully removes the ability to save a polygon using the geotrace widget. This means that users who rely on their enumerators picking trace or shape will need to redeploy their forms or block updates as described on the forum.
Although the intent is just to modify geotrace, code is shared between geotrace and geoshape so both are at risk of regressions. There's no risk that the change affects different Android versions differently so verification on one Android version should be enough.
Do we need any specific form for testing your changes? If so, please attach one.
All Widgets
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/docs#968
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.