Support long press to add points #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's very likely that this release will be pushed back by a day or two but if there's time, it would be good to have this go through QA so it can be merged immediately if everyone is on board. It's a tiny change so hopefully doesn't require much time at all! |
|
Tested with success Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 Long press and tap can be used to adding locations. Both methods can be mixed. @opendatakit-bot unlabel "needs testing" |
|
@opendatakit-bot label "behavior verified" |
yanokwa
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2975
What has been done to verify that this works as intended?
Added points by long pressing and single-tapping.
Why is this the best possible solution? Were any other approaches considered?
This is such a small change that there is no other possible approach. There is a question about whether it's a good idea to do, though, so I've tagged as
needs discussion.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should not change any existing behavior. It adds another way to add points. Since long press isn't used for anything else in the geo widgets, I don't think there's any danger.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with geo widgets.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.