Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Repeat group picker" UI for FormHierarchy #2740

Merged
merged 25 commits into from
Dec 17, 2018
Merged

"Repeat group picker" UI for FormHierarchy #2740

merged 25 commits into from
Dec 17, 2018

Commits on Nov 30, 2018

  1. Factor out jumpToHierarchyStartIndex

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    3c2d4ca View commit details
    Browse the repository at this point in the history

  2. Call refreshView instead of manual expand/collapse 

    This doesn't yet render anything new.
    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    cae805a View commit details
    Browse the repository at this point in the history

  3. Set repeatGroupPickerRef in order to render 'picker' view

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    c3034ad View commit details
    Browse the repository at this point in the history

  4. Handle 'go up' when in the picker view

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    bea5530 View commit details
    Browse the repository at this point in the history

  5. Clarify currentIndex docs

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    edd3ef7 View commit details
    Browse the repository at this point in the history

  6. Always step out to the closest screen event 

    This ensures a consistent form reference.

For example, without this change, if the user is on a question
then opens the jump screen, the index will be of the question
and not of the repeat group.
    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b08e644 View commit details
    Browse the repository at this point in the history

  7. Toggle the picker if coming from an inner repeat group

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b7174e0 View commit details
    Browse the repository at this point in the history

  8. Also show groupPath for the root picker 

    Currently no text to display, but at least render the UI.
    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a3b8e3f View commit details
    Browse the repository at this point in the history

  9. Safe repeatGroupPickerIndex instead of repeatGroupPickerRef

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a434aa3 View commit details
    Browse the repository at this point in the history

  10. Show repeat picker 'label' in groupPath

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    07a0f29 View commit details
    Browse the repository at this point in the history

  11. Compare unindexed ref to support nested repeat groups

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9524be3 View commit details
    Browse the repository at this point in the history

  12. Replace dropdown icon with 'Repeatable Group' label

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    20427ee View commit details
    Browse the repository at this point in the history

  13. Remove now-obsolete code from HierarchyElement

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b7a4391 View commit details
    Browse the repository at this point in the history

  14. Factor out shouldShowRepeatGroupPicker()

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    f29259e View commit details
    Browse the repository at this point in the history

  15. Add clarifying comments in goUpLevel()

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1585e20 View commit details
    Browse the repository at this point in the history

  16. Fix checks 

    Remove unused imports; add braces; remove unused drawables.
    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    c3b6646 View commit details
    Browse the repository at this point in the history

  17. Use 'instance' instead of 'child' when possible

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    f69b591 View commit details
    Browse the repository at this point in the history

  18. Clean up old comments

    @cooperka
    cooperka committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    77ac22d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Remove default toString arg

    @cooperka
    cooperka committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    fa64d61 View commit details
    Browse the repository at this point in the history

  2. Rename obsolete PARENT and CHILD types

    @cooperka
    cooperka committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    7907ad7 View commit details
    Browse the repository at this point in the history

  3. Add repeat icon to repeatable groups in hierarchy

    @cooperka
    cooperka committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    3683821 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Remember repeatGroupPickerIndex on screen rotation 

    Manually restoreInstanceState because onRestoreInstanceState
happens too late after onCreate.
    @cooperka
    cooperka committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    ac693e6 View commit details
    Browse the repository at this point in the history

  2. Don't try to scroll anywhere when entering/exiting the picker 

    This logic was obsolete; probably related to old expand/collapse behavior.
setAdapter is also already called by refreshView, so no need for it here.

Standardize on 'break' instead of 'return' for consistency.
    @cooperka
    cooperka committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    8412441 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Fix restoreInstanceState protected => private

    @cooperka
    cooperka authored Dec 14, 2018
    Configuration menu
    Copy the full SHA
    a728d13 View commit details
    Browse the repository at this point in the history

  2. Reverse restoreInstanceState condition

    @cooperka
    cooperka committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    1bb55e9 View commit details
    Browse the repository at this point in the history