Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about Google billing accounts for API keys #2611

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Oct 3, 2018

The Google maps API key process has changed in the last few months. I also added an explanation for why the keys that are in the source code 1) don't work for debug builds 2) are ok to leave in unprotected.

What has been done to verify that this works as intended?

I have tried the instructions and successfully generated a Google Maps API key. I read through the terms and confirmed that a trial credit is included and that the card won't be billed without a confirmation.

Why is this the best possible solution? Were any other approaches considered?

It's a matter-of-fact description of the current state of things. I considered bolding or italicizing parts of the message but thought that was too aggressive.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It warns users ahead of time about the billing process so they won't try to get a key if they don't have a credit card, for example. It's a little scary/offputting but I don't think we have a choice if we keep using the Google Maps API.

Do we need any specific form for testing your changes? If so, please attach one.

No

Does this change require updates to documentation? If so, please file an issue here and include the link below.

This is it!

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel merged commit 62ea57b into master Oct 8, 2018
@lognaturel lognaturel deleted the google-billing branch October 8, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants